linux-kernel - Re: [PATCH][linux-next] net/mlx5: Bridge, fix uninitialized variable in mlx5_esw_bridge_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ygnh8s0ypumc.fsf@nvidia.com>
Date:   Wed, 18 Aug 2021 19:47:55 +0300
From:   Vlad Buslov <vladbu@...dia.com>
To:     Saeed Mahameed <saeedm@...dia.com>,
        Tim Gardner <tim.gardner@...onical.com>
CC:     <linux-kernel@...r.kernel.org>, Leon Romanovsky <leon@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Jianbo Liu" <jianbol@...dia.com>, Mark Bloch <mbloch@...dia.com>,
        Roi Dayan <roid@...dia.com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH][linux-next] net/mlx5: Bridge, fix uninitialized
 variable in mlx5_esw_bridge_port_changeupper()

On Wed 18 Aug 2021 at 18:52, Tim Gardner <tim.gardner@...onical.com> wrote:
> A recent change removed code that initialized the return code variable 'err'. It
> is now possible for mlx5_esw_bridge_port_changeupper() to return an error code
> using this uninitialized variable. Fix it by initializing to 0.
>
> Addresses-Coverity: ("Uninitialized scalar variable (UNINIT)")
>
> Cc: Saeed Mahameed <saeedm@...dia.com>
> Cc: Leon Romanovsky <leon@...nel.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Vlad Buslov <vladbu@...dia.com>
> Cc: Jianbo Liu <jianbol@...dia.com>
> Cc: Mark Bloch <mbloch@...dia.com>
> Cc: Roi Dayan <roid@...dia.com>
> Cc: Vladimir Oltean <vladimir.oltean@....com>
> Cc: netdev@...r.kernel.org
> Cc: linux-rdma@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Tim Gardner <tim.gardner@...onical.com>
> ---

Tim, thanks for fixing this!

Saeed, this is the second similar issue that I mentioned in my reply to
Colin. Again, I've already submitted same patch internally and this one
is as good as mine.

Reviewed-by: Vlad Buslov <vladbu@...dia.com>

[...]