linux-kernel - RE: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB9PR04MB8411835BFAE26A3E1C4681F892C09@DB9PR04MB8411.eurprd04.prod.outlook.com>
Date:   Thu, 19 Aug 2021 01:27:51 +0000
From:   Sherry Sun <sherry.sun@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value

Hi Greg,

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: 2021年8月18日 22:05
> To: Sherry Sun <sherry.sun@....com>
> Cc: jirislaby@...nel.org; linux-serial@...r.kernel.org; linux-
> kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH] tty: serial: fsl_lpuart: fix the wrong mapbase value
> 
> On Tue, Aug 17, 2021 at 02:30:58PM +0800, Sherry Sun wrote:
> > From: Andy Duan <fugang.duan@....com>
> >
> > Register offset needs to be applied on mapbase also.
> > dma_tx/rx_request use the physical address of UARTDATA.
> > Register offset is currently only applied to membase (the
> > corresponding virtual addr) but not on mapbase.
> >
> > Reviewed-by: Leonard Crestez <leonard.crestez@....com>
> > Acked-by: Fugang Duan <fugang.duan@....com>
> > Signed-off-by: Adriana Reus <adriana.reus@....com>
> > Signed-off-by: Sherry Sun <sherry.sun@....com>
> > ---
> 
> Why is there no signed-off-by from the author?
> 
> Please fix up.

Sure, will add it in V2, thanks!

> 
> thanks,
> 
> greg k-h