linux-kernel - Re: [PATCH 1/6] staging: r8188eu: remove _dbg_dump_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9701067.u0aNz3o6e4@localhost.localdomain>
Date:   Thu, 19 Aug 2021 03:34:31 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     gregkh@...uxfoundation.org, Phillip Potter <phil@...lpotter.co.uk>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        martin@...ser.cx, straube.linux@...il.com,
        Larry.Finger@...inger.net
Subject: Re: [PATCH 1/6] staging: r8188eu: remove _dbg_dump_tx_info function

On Thursday, August 19, 2021 1:42:48 AM CEST Phillip Potter wrote:
> Remove _dbg_dump_tx_info from hal/rtl8188e_xmit.c as it is just a
> dumping function that contains a lot of unclear DBG_88E calls, and has
> no other external effect, other than calling a function that ultimately
> determines whether or not to dump/trigger the DBG_88E calls. Also remove
> its declaration and single call site.
> 
> Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
> ---
>  drivers/staging/r8188eu/hal/rtl8188e_xmit.c   | 31 -------------------
>  drivers/staging/r8188eu/hal/rtl8188eu_xmit.c  |  1 -
>  .../staging/r8188eu/include/rtl8188e_xmit.h   |  3 --
>  3 files changed, 35 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_xmit.c b/drivers/staging/r8188eu/hal/rtl8188e_xmit.c
> index 164ec6650dec..d2b55d581f95 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_xmit.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_xmit.c
> @@ -42,34 +42,3 @@ void handle_txrpt_ccx_88e(struct adapter *adapter, u8 *buf)
>  					RTW_SCTX_DONE_CCX_PKT_FAIL);
>  	}
>  }
> -
> -void _dbg_dump_tx_info(struct adapter *padapter, int frame_tag,
> -		       struct tx_desc *ptxdesc)
> -{
> -	u8 dmp_txpkt;
> -	bool dump_txdesc = false;
> -	rtw_hal_get_def_var(padapter, HAL_DEF_DBG_DUMP_TXPKT, &(dmp_txpkt));
> -
> -	if (dmp_txpkt == 1) {/* dump txdesc for data frame */
> -		DBG_88E("dump tx_desc for data frame\n");
> -		if ((frame_tag & 0x0f) == DATA_FRAMETAG)
> -			dump_txdesc = true;
> -	} else if (dmp_txpkt == 2) {/* dump txdesc for mgnt frame */
> -		DBG_88E("dump tx_desc for mgnt frame\n");
> -		if ((frame_tag & 0x0f) == MGNT_FRAMETAG)
> -			dump_txdesc = true;
> -	}
> -
> -	if (dump_txdesc) {
> -		DBG_88E("=====================================\n");
> -		DBG_88E("txdw0(0x%08x)\n", ptxdesc->txdw0);
> -		DBG_88E("txdw1(0x%08x)\n", ptxdesc->txdw1);
> -		DBG_88E("txdw2(0x%08x)\n", ptxdesc->txdw2);
> -		DBG_88E("txdw3(0x%08x)\n", ptxdesc->txdw3);
> -		DBG_88E("txdw4(0x%08x)\n", ptxdesc->txdw4);
> -		DBG_88E("txdw5(0x%08x)\n", ptxdesc->txdw5);
> -		DBG_88E("txdw6(0x%08x)\n", ptxdesc->txdw6);
> -		DBG_88E("txdw7(0x%08x)\n", ptxdesc->txdw7);
> -		DBG_88E("=====================================\n");
> -	}
> -}
> diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
> index 50c4b9382761..b279309405a2 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c
> @@ -330,7 +330,6 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag
>  	ODM_SetTxAntByTxInfo_88E(&haldata->odmpriv, pmem, pattrib->mac_id);
>  
>  	rtl8188eu_cal_txdesc_chksum(ptxdesc);
> -	_dbg_dump_tx_info(adapt, pxmitframe->frame_tag, ptxdesc);
>  	return pull;
>  }
>  
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_xmit.h b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> index ff8b73441c52..d2099da1a41a 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> @@ -153,7 +153,4 @@ s32 rtl8188eu_xmitframe_complete(struct adapter *padapter,
>  void dump_txrpt_ccx_88e(void *buf);
>  void handle_txrpt_ccx_88e(struct adapter *adapter, u8 *buf);
>  
> -void _dbg_dump_tx_info(struct adapter *padapter, int frame_tag,
> -		       struct tx_desc *ptxdesc);
> -
>  #endif /* __RTL8188E_XMIT_H__ */
> -- 
> 2.31.1
> 
At a quick look it looks good. 

Built with "make C=2 -j8 drivers/staging/r8188eu/ W=1"
on x86-64, it does not introduce any errors or warnings, so...

Acked-by: Fabio M. De Francesco <fmdefrancesco@...il.com>

Thanks,

Fabio