linux-kernel - Re: [PATCH 2/6] staging: r8188eu: remove unused function dump_txrpt_ccx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3469308.GW2Jk8YpuN@localhost.localdomain>
Date:   Thu, 19 Aug 2021 03:38:41 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     gregkh@...uxfoundation.org, Phillip Potter <phil@...lpotter.co.uk>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        martin@...ser.cx, straube.linux@...il.com,
        Larry.Finger@...inger.net
Subject: Re: [PATCH 2/6] staging: r8188eu: remove unused function dump_txrpt_ccx_88e

On Thursday, August 19, 2021 1:42:49 AM CEST Phillip Potter wrote:
> Remove unused function dump_txrpt_ccx_88e from hal/rtl8188e_xmit.c and
> remove its declaration in include/rtl8188e_xmit.h, as this function is
> not called from anywhere, and is thus dead code.
> 
> Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
> ---
>  drivers/staging/r8188eu/hal/rtl8188e_xmit.c   | 22 -------------------
>  .../staging/r8188eu/include/rtl8188e_xmit.h   |  1 -
>  2 files changed, 23 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_xmit.c b/drivers/staging/r8188eu/hal/rtl8188e_xmit.c
> index d2b55d581f95..46b871f3f631 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_xmit.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_xmit.c
> @@ -7,28 +7,6 @@
>  #include "../include/drv_types.h"
>  #include "../include/rtl8188e_hal.h"
>  
> -void dump_txrpt_ccx_88e(void *buf)
> -{
> -	struct txrpt_ccx_88e *txrpt_ccx = (struct txrpt_ccx_88e *)buf;
> -
> -	DBG_88E("%s:\n"
> -		"tag1:%u, pkt_num:%u, txdma_underflow:%u, int_bt:%u, int_tri:%u, int_ccx:%u\n"
> -		"mac_id:%u, pkt_ok:%u, bmc:%u\n"
> -		"retry_cnt:%u, lifetime_over:%u, retry_over:%u\n"
> -		"ccx_qtime:%u\n"
> -		"final_data_rate:0x%02x\n"
> -		"qsel:%u, sw:0x%03x\n",
> -		__func__, txrpt_ccx->tag1, txrpt_ccx->pkt_num,
> -		txrpt_ccx->txdma_underflow, txrpt_ccx->int_bt,
> -		txrpt_ccx->int_tri, txrpt_ccx->int_ccx,
> -		txrpt_ccx->mac_id, txrpt_ccx->pkt_ok, txrpt_ccx->bmc,
> -		txrpt_ccx->retry_cnt, txrpt_ccx->lifetime_over,
> -		txrpt_ccx->retry_over, txrpt_ccx_qtime_88e(txrpt_ccx),
> -		txrpt_ccx->final_data_rate, txrpt_ccx->qsel,
> -		txrpt_ccx_sw_88e(txrpt_ccx)
> -	);
> -}
> -
>  void handle_txrpt_ccx_88e(struct adapter *adapter, u8 *buf)
>  {
>  	struct txrpt_ccx_88e *txrpt_ccx = (struct txrpt_ccx_88e *)buf;
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_xmit.h b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> index d2099da1a41a..20b55e3850ba 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> @@ -150,7 +150,6 @@ s32 rtl8188eu_xmitframe_complete(struct adapter *padapter,
>  				 struct xmit_priv *pxmitpriv,
>  				 struct xmit_buf *pxmitbuf);
>  
> -void dump_txrpt_ccx_88e(void *buf);
>  void handle_txrpt_ccx_88e(struct adapter *adapter, u8 *buf);
>  
>  #endif /* __RTL8188E_XMIT_H__ */
> -- 
> 2.31.1
> 
At a quick look it looks good. 

Built with "make C=2 -j8 drivers/staging/r8188eu/ W=1"
on x86-64, it does not introduce any errors or warnings, so...

Acked-by: Fabio M. De Francesco <fmdefrancesco@...il.com>

Thanks,

Fabio