linux-kernel - Re: [PATCH 3/6] staging: r8188eu: remove txrpt_ccx_sw_88e and txrpt_ccx_qtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Aug 2021 03:56:06 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     gregkh@...uxfoundation.org, Phillip Potter <phil@...lpotter.co.uk>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        martin@...ser.cx, straube.linux@...il.com,
        Larry.Finger@...inger.net
Subject: Re: [PATCH 3/6] staging: r8188eu: remove txrpt_ccx_sw_88e and txrpt_ccx_qtime_88e macros

On Thursday, August 19, 2021 1:42:50 AM CEST Phillip Potter wrote:
> Remove txrpt_ccx_sw_88e and txrpt_ccx_qtime_88e macro definitions from
> include/rtl8188e_xmit.h, as these were only called from the now removed
> dump_txrpt_ccx_88e function, which was itself not called from anywhere
> anyway.
> 
> Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
> ---
>  drivers/staging/r8188eu/include/rtl8188e_xmit.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_xmit.h b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> index 20b55e3850ba..e7eb19c4ee9d 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> @@ -133,10 +133,6 @@ struct txrpt_ccx_88e {
>  	u8 sw0;
>  };
>  
> -#define txrpt_ccx_sw_88e(txrpt_ccx) ((txrpt_ccx)->sw0 + ((txrpt_ccx)->sw1<<8))
> -#define txrpt_ccx_qtime_88e(txrpt_ccx)			\
> -	((txrpt_ccx)->ccx_qtime0+((txrpt_ccx)->ccx_qtime1<<8))
> -
>  void rtl8188e_fill_fake_txdesc(struct adapter *padapter, u8 *pDesc,
>  			       u32 BufferLen, u8 IsPsPoll, u8 IsBTQosNull);
>  s32 rtl8188eu_init_xmit_priv(struct adapter *padapter);
> -- 
> 2.31.1
> 
At a quick look it looks good. 

Built with "make C=2 -j8 drivers/staging/r8188eu/ W=1"
on x86-64, it does not introduce any errors or warnings, so...

Acked-by: Fabio M. De Francesco <fmdefrancesco@...il.com>

Thanks,

Fabio