linux-kernel - Re: [PATCH 4/6] staging: r8188eu: remove empty function rtl8188eu_free_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3783001.X7UpCbk0Mo@localhost.localdomain>
Date:   Thu, 19 Aug 2021 04:00:25 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     gregkh@...uxfoundation.org, Phillip Potter <phil@...lpotter.co.uk>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        martin@...ser.cx, straube.linux@...il.com,
        Larry.Finger@...inger.net
Subject: Re: [PATCH 4/6] staging: r8188eu: remove empty function rtl8188eu_free_xmit_priv

On Thursday, August 19, 2021 1:42:51 AM CEST Phillip Potter wrote:
> Remove empty function rtl8188eu_free_xmit_priv from hal/rtl8188eu_xmit.c
> and its declaration from include/rtl8188e_xmit.h, as well as the one
> place where it is stored in the free_xmit_priv function pointer of the
> HalFunc struct inside padapter. This is safe, as the wrapper function
> checks for NULL before calling this function via the function pointer.
> 
> Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
> ---
>  drivers/staging/r8188eu/hal/rtl8188eu_xmit.c    | 4 ----
>  drivers/staging/r8188eu/hal/usb_halinit.c       | 1 -
>  drivers/staging/r8188eu/include/rtl8188e_xmit.h | 1 -
>  3 files changed, 6 deletions(-)
> 
It looks good, so...

Acked-by: Fabio M. De Francesco

Thanks,

Fabio