linux-kernel - Re: [PATCH 5/6] staging: r8188eu: remove function rtw_hal_free_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Aug 2021 04:08:22 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     gregkh@...uxfoundation.org, Phillip Potter <phil@...lpotter.co.uk>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        martin@...ser.cx, straube.linux@...il.com,
        Larry.Finger@...inger.net
Subject: Re: [PATCH 5/6] staging: r8188eu: remove function rtw_hal_free_xmit_priv

On Thursday, August 19, 2021 1:42:52 AM CEST Phillip Potter wrote:
> Remove function rtw_hal_free_xmit_priv in hal/hal_intf.c and its
> declaration in include/hal_intf.h, as well as the single call line in
> core/rtw_xmit.c. This function now essentially checks a function
> pointer which will always be NULL (due to previous patches) and
> therefore will never be called.
> 
> Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
> ---
>  drivers/staging/r8188eu/core/rtw_xmit.c    | 2 --
>  drivers/staging/r8188eu/hal/hal_intf.c     | 6 ------
>  drivers/staging/r8188eu/include/hal_intf.h | 1 -
>  3 files changed, 9 deletions(-)

It looks good. 

Built with "make C=2 -j8 drivers/staging/r8188eu/ W=1"
on x86-64, it does not introduce errors or new warnings, so...

Acked-by: Fabio M. De Francesco <fmdefrancesco@...il.com>

Thanks,

Fabio