linux-kernel - Re: [PATCH v3] Bluetooth: Fix return value in hci_dev_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <C0D6D79E-7325-4A7C-9153-FB35A88DD9CB@holtmann.org>
Date:   Thu, 19 Aug 2021 17:07:37 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Kangmin Park <l4stpr0gr4m@...il.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Tedd Ho-Jeong An <tedd.an@...el.com>,
        linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Bluetooth: Fix return value in hci_dev_do_close()

Hi Kangmin,

> hci_error_reset() return without calling hci_dev_do_open() when
> hci_dev_do_close() return error value which is not 0.
> 
> Also, hci_dev_close() return hci_dev_do_close() function's return
> value.
> 
> But, hci_dev_do_close() return always 0 even if hdev->shutdown
> return error value. So, fix hci_dev_do_close() to save and return
> the return value of the hdev->shutdown when it is called.
> 
> Signed-off-by: Kangmin Park <l4stpr0gr4m@...il.com>
> ---
> net/bluetooth/hci_core.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index 8622da2d9395..84afc0d693a8 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -1718,6 +1718,7 @@ static void hci_pend_le_actions_clear(struct hci_dev *hdev)
> int hci_dev_do_close(struct hci_dev *hdev)
> {
> 	bool auto_off;
> +	int ret = 0;
> 
> 	BT_DBG("%s %p", hdev->name, hdev);
> 
> @@ -1732,13 +1733,13 @@ int hci_dev_do_close(struct hci_dev *hdev)
> 	    test_bit(HCI_UP, &hdev->flags)) {
> 		/* Execute vendor specific shutdown routine */
> 		if (hdev->shutdown)
> -			hdev->shutdown(hdev);
> +			ret = hdev->shutdown(hdev);
> 	}
> 
> 	if (!test_and_clear_bit(HCI_UP, &hdev->flags)) {
> 		cancel_delayed_work_sync(&hdev->cmd_timer);
> 		hci_req_sync_unlock(hdev);
> -		return 0;
> +		return ret;
> 	}
> 
> 	hci_leds_update_powered(hdev, false);
> @@ -1845,7 +1846,7 @@ int hci_dev_do_close(struct hci_dev *hdev)
> 	hci_req_sync_unlock(hdev);
> 
> 	hci_dev_put(hdev);
> -	return 0;
> +	return ret;
> }

actually use variable name err instead of ret since that is more consistent in this code.

Regards

Marcel