linux-kernel - Re: [PATCH v2] staging: r8188eu: Remove _enter/_exit_critical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202108192232.FikYor4C-lkp@intel.com>
Date:   Thu, 19 Aug 2021 23:08:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Martin Kaiser <martin@...ser.cx>,
        Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Subject: Re: [PATCH v2] staging: r8188eu: Remove _enter/_exit_critical_mutex()

Hi "Fabio,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Fabio-M-De-Francesco/staging-r8188eu-Remove-_enter-_exit_critical_mutex/20210819-205259
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 093991aaadf0fbb34184fa37a46e7a157da3f386
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/be2317351161f572a68f71544046d8491856818f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Fabio-M-De-Francesco/staging-r8188eu-Remove-_enter-_exit_critical_mutex/20210819-205259
        git checkout be2317351161f572a68f71544046d8491856818f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/staging/r8188eu/core/rtw_mlme_ext.c: In function 'dump_mgntframe_and_wait_ack':
>> drivers/staging/r8188eu/core/rtw_mlme_ext.c:4363:17: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
    4363 |                 ;       /*ignore return value */
         |                 ^
--
   drivers/staging/r8188eu/hal/usb_ops_linux.c: In function 'usbctrl_vendorreq':
>> drivers/staging/r8188eu/hal/usb_ops_linux.c:36:17: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
      36 |                 ;       /* ignore return value */
         |                 ^
--
   drivers/staging/r8188eu/os_dep/os_intfs.c: In function 'netdev_open':
>> drivers/staging/r8188eu/os_dep/os_intfs.c:1069:17: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
    1069 |                 ;       /* ignore return value */
         |                 ^


vim +/if +4363 drivers/staging/r8188eu/core/rtw_mlme_ext.c

  4352	
  4353	s32 dump_mgntframe_and_wait_ack(struct adapter *padapter, struct xmit_frame *pmgntframe)
  4354	{
  4355		s32 ret = _FAIL;
  4356		u32 timeout_ms = 500;/*   500ms */
  4357		struct xmit_priv	*pxmitpriv = &padapter->xmitpriv;
  4358	
  4359		if (padapter->bSurpriseRemoved || padapter->bDriverStopped)
  4360			return -1;
  4361	
  4362		if (mutex_lock_interruptible(&pxmitpriv->ack_tx_mutex))
> 4363			;	/*ignore return value */
  4364		pxmitpriv->ack_tx = true;
  4365	
  4366		pmgntframe->ack_report = 1;
  4367		if (rtw_hal_mgnt_xmit(padapter, pmgntframe) == _SUCCESS) {
  4368			ret = rtw_ack_tx_wait(pxmitpriv, timeout_ms);
  4369		}
  4370	
  4371		pxmitpriv->ack_tx = false;
  4372		mutex_unlock(&pxmitpriv->ack_tx_mutex);
  4373	
  4374		return ret;
  4375	}
  4376	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (60728 bytes)