[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CABVgOSnPVy0St9QHHt_ePFqFmR2MWzLK4BKmky2k2+ABECZbkw@mail.gmail.com>
Date: Fri, 20 Aug 2021 01:57:01 +0800
From: David Gow <davidgow@...gle.com>
To: Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-staging@...ts.linux.dev, kernel-janitors@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: staging: correct reference to config IOMEM to config HAS_IOMEM
On Tue, Aug 17, 2021 at 6:54 PM Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:
>
> Commit 0a0a66c984b3 ("clk: staging: Specify IOMEM dependency for Xilinx
> Clocking Wizard driver") introduces a dependency on the non-existing config
> IOMEM, which basically makes it impossible to include this driver into any
> build. Fortunately, ./scripts/checkkconfigsymbols.py warns:
>
> IOMEM
> Referencing files: drivers/staging/clocking-wizard/Kconfig
>
> The config for IOMEM support is called HAS_IOMEM. Correct this reference to
> the intended config.
>
> Fixes: 0a0a66c984b3 ("clk: staging: Specify IOMEM dependency for Xilinx Clocking Wizard driver")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
Whoops! Thanks for picking up on this: I thought I'd fixed it, but it
was actually for another driver.
Reviewed-by: David Gow <davidgow@...gle.com>
Cheers,
-- David
Powered by blists - more mailing lists