linux-kernel - RE: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OSZPR01MB7019F9AF40E5E8626DD0E168AAC19@OSZPR01MB7019.jpnprd01.prod.outlook.com>
Date:   Fri, 20 Aug 2021 14:04:15 +0000
From:   Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
CC:     "jic23@...nel.org" <jic23@...nel.org>
Subject: RE: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in
 rzg2l_adc_pm_runtime_resume()

Hi Yang,

Thank you for the patch.

> -----Original Message-----
> From: Yang Yingliang <yangyingliang@...wei.com>
> Sent: 19 August 2021 14:24
> To: linux-kernel@...r.kernel.org; linux-iio@...r.kernel.org
> Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>; jic23@...nel.org
> Subject: [PATCH -next] iio: adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()
> 
> Add clk_disable_unprepare() on error path in rzg2l_adc_pm_runtime_resume().
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/iio/adc/rzg2l_adc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
With subject line changed to, iio: adc: rzg2l_adc: add missing clk_disable_unprepare() in rzg2l_adc_pm_runtime_resume()

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c index
> 9996d5eef289..c38f43ea624f 100644
> --- a/drivers/iio/adc/rzg2l_adc.c
> +++ b/drivers/iio/adc/rzg2l_adc.c
> @@ -570,8 +570,10 @@ static int __maybe_unused rzg2l_adc_pm_runtime_resume(struct device *dev)
>  		return ret;
> 
>  	ret = clk_prepare_enable(adc->adclk);
> -	if (ret)
> +	if (ret) {
> +		clk_disable_unprepare(adc->pclk);
>  		return ret;
> +	}
> 
>  	rzg2l_adc_pwr(adc, true);
> 
> --
> 2.25.1