[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7efb04fe6e0c867e7c87d75cf3349221b08b4210.camel@kernel.org>
Date: Fri, 20 Aug 2021 11:50:51 -0400
From: Jeff Layton <jlayton@...nel.org>
To: David Laight <David.Laight@...LAB.COM>,
"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
"david@...hat.com" <david@...hat.com>,
"willy@...radead.org" <willy@...radead.org>,
"linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"v9fs-developer@...ts.sourceforge.net"
<v9fs-developer@...ts.sourceforge.net>,
"linux-afs@...ts.infradead.org" <linux-afs@...ts.infradead.org>,
"cluster-devel@...hat.com" <cluster-devel@...hat.com>,
"ocfs2-devel@....oracle.com" <ocfs2-devel@....oracle.com>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
"luto@...nel.org" <luto@...nel.org>,
"bfields@...ldses.org" <bfields@...ldses.org>,
"w@....eu" <w@....eu>, "rostedt@...dmis.org" <rostedt@...dmis.org>,
"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] fs: warn about impending deprecation of
mandatory locks
On Fri, 2021-08-20 at 15:49 +0000, David Laight wrote:
> From: Jeff Layton
> > Sent: 20 August 2021 14:57
> >
> > We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros
> > have disabled it. Warn the stragglers that still use "-o mand" that
> > we'll be dropping support for that mount option.
> >
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Jeff Layton <jlayton@...nel.org>
> > ---
> > fs/namespace.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/fs/namespace.c b/fs/namespace.c
> > index ab4174a3c802..ffab0bb1e649 100644
> > --- a/fs/namespace.c
> > +++ b/fs/namespace.c
> > @@ -1716,8 +1716,16 @@ static inline bool may_mount(void)
> > }
> >
> > #ifdef CONFIG_MANDATORY_FILE_LOCKING
> > +static bool warned_mand;
> > static inline bool may_mandlock(void)
> > {
> > + if (!warned_mand) {
> > + warned_mand = true;
> > + pr_warn("======================================================\n");
> > + pr_warn("WARNING: the mand mount option is being deprecated and\n");
> > + pr_warn(" will be removed in v5.15!\n");
> > + pr_warn("======================================================\n");
> > + }
> > return capable(CAP_SYS_ADMIN);
> > }
>
> If that is called more than once you don't want the 'inline'.
> I doubt it matters is not inlined - hardly a hot path.
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>
ACK. Of course. That really needs to not be inline. I'll fix that up in
my tree.
Thanks!
--
Jeff Layton <jlayton@...nel.org>
Powered by blists - more mailing lists