linux-kernel - Re: [PATCH] MIPS: Return true/false (not 1/0) from bool functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210821084052.GA3555@alpha.franken.de>
Date:   Sat, 21 Aug 2021 10:40:52 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Huilong Deng <denghuilong@...rlc.com>
Cc:     chenhuacai@...nel.org, aleksandar.qemu.devel@...il.com,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Return true/false (not 1/0) from bool functions

On Tue, Aug 17, 2021 at 10:53:38AM +0800, Huilong Deng wrote:
> ./arch/mips/kernel/uprobes.c:261:8-9: WARNING: return of 0/1 in function
> 'arch_uprobe_skip_sstep' with return type bool
> ./arch/mips/kernel/uprobes.c:78:10-11: WARNING: return of 0/1 in
> function 'is_trap_insn' with return type bool
> ./arch/mips/kvm/mmu.c:489:9-10: WARNING: return of 0/1 in function
> 'kvm_test_age_gfn' with return type bool
> ./arch/mips/kvm/mmu.c:445:8-9: WARNING: return of 0/1 in function
> 'kvm_unmap_gfn_range' with return type bool
> 
> Signed-off-by: Huilong Deng <denghuilong@...rlc.com>
> ---
>  arch/mips/kernel/uprobes.c | 10 +++++-----
>  arch/mips/kvm/mmu.c        |  4 ++--
>  2 files changed, 7 insertions(+), 7 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]