[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210821084205.GD3555@alpha.franken.de>
Date: Sat, 21 Aug 2021 10:42:05 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>,
devicetree@...r.kernel.org, UNGLinuxDriver@...rochip.com,
Horatiu Vultur <horatiu.vultur@...rochip.com>,
Rob Herring <robh+dt@...nel.org>, linux-mips@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH devicetree 2/2] MIPS: mscc: ocelot: mark the phy-mode for
internal PHY ports
On Thu, Aug 19, 2021 at 08:04:16PM +0300, Vladimir Oltean wrote:
> The ocelot driver was converted to phylink, and that expects a valid
> phy_interface_t. Without a phy-mode, of_get_phy_mode returns
> PHY_INTERFACE_MODE_NA, which is not ideal because phylink rejects that.
>
> The ocelot driver was patched to treat PHY_INTERFACE_MODE_NA as
> PHY_INTERFACE_MODE_INTERNAL to work with the broken DT blobs, but we
> should fix the device trees and specify the phy-mode too.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
> arch/mips/boot/dts/mscc/ocelot_pcb120.dts | 4 ++++
> arch/mips/boot/dts/mscc/ocelot_pcb123.dts | 4 ++++
> 2 files changed, 8 insertions(+)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
Powered by blists - more mailing lists