linux-kernel - Re: [PATCH 2/2] dt-bindings: hwmon: merge max31785 into trivial devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Aug 2021 16:12:22 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Jean Delvare <jdelvare@...e.com>, Jiri Kosina <trivial@...nel.org>,
        Linux HWMON List <linux-hwmon@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: hwmon: merge max31785 into trivial devices

On Fri, Aug 20, 2021 at 9:23 AM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote:
> > Ther Maxim max31785 bindings are trivial, so simply merge it into
> > trivial-devices.yaml.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> > ---
> >   .../devicetree/bindings/hwmon/max31785.txt    | 22 -------------------
>
> Not sure if that is a good idea. It would make more sense to standardize the
> properties needed by the driver/chip instead (see existing dts files in the kernel).

This device is certainly not trivial, the binding is just incomplete.

Device specific fan controller bindings are something I'm just going
to reject until someone comes up with something common.

Rob