linux-kernel - Re: [PATCH 1/2] dt-bindings: hwmon: merge max1619 into trivial devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKJgvK8g+zbzLCBxnKbgAioBcdHWNAvqe4Z9BzkNMwPpA@mail.gmail.com>
Date:   Mon, 23 Aug 2021 16:19:47 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Jean Delvare <jdelvare@...e.com>,
        Jiri Kosina <trivial@...nel.org>,
        Linux HWMON List <linux-hwmon@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: merge max1619 into trivial devices

On Fri, Aug 20, 2021 at 9:26 AM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On 8/19/21 11:25 AM, Krzysztof Kozlowski wrote:
> > Ther Maxim max1619 bindings are trivial, so simply merge it into
> > trivial-devices.yaml.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>
> Do we have a general guideline on how to handle such trivial bindings ?

Not really. I debate (with myself) just getting rid of it as I suspect
lots of bindings are just incomplete. Like should supplies be
required? But it's convenient to have and not duplicate a bunch of
boilerplate.

> I normally leave it up to the driver author to decide one way or another.

Me too.

This one looks simple enough to be in trivial-devices, so I'll take
having a schema over not.

Rob