linux-kernel - Re: [PATCH linux-next] alpha:smp: fix warning comparing pointer to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEdQ38FvspQYf75wMuNKDpj+C1agXdLzfvjYR3fud+V=iXP_JQ@mail.gmail.com>
Date:   Sun, 22 Aug 2021 19:01:56 -0700
From:   Matt Turner <mattst88@...il.com>
To:     CGEL <cgel.zte@...il.com>
Cc:     Richard Henderson <rth@...ddle.net>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        linux-alpha <linux-alpha@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jing Yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] alpha:smp: fix warning comparing pointer to 0

On Sun, Aug 22, 2021 at 6:49 PM CGEL <cgel.zte@...il.com> wrote:
>
> From: Jing Yangyang <jing.yangyang@....com.cn>
>
> Fix the following coccicheck warning:
> ./arch/alpha/kernel/smp.c:271:39-40:
> WARNING:comparing pointer to 0
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang@....com.cn>
> ---
>  arch/alpha/kernel/smp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c
> index cb64e47..adc05c2 100644
> --- a/arch/alpha/kernel/smp.c
> +++ b/arch/alpha/kernel/smp.c
> @@ -268,7 +268,7 @@ enum ipi_message_type {
>                         memcpy(cp2, cp1, cnt);
>                         cp2[cnt] = '\0';
>
> -                       while ((cp2 = strchr(cp2, '\r')) != 0) {

You may as well compare with NULL, for clarity.