linux-kernel - Re: [PATCH -next v2 0/3] riscv: Fix two vdso issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Aug 2021 10:02:40 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Tong Tiangen <tongtiangen@...wei.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        "Palmer Dabbelt" <palmerdabbelt@...gle.com>,
        Albert Ou <aou@...s.berkeley.edu>
CC:     <linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next v2 0/3] riscv: Fix two vdso issue


On 2021/8/20 20:50, Tong Tiangen wrote:
> v2->v1:
>   Add patch "Refactor asm/vdso.h" to avoid vdso.lds syntax error if
>   CONFIG_GENERIC_TIME_VSYSCALL=n.

This is better than v1.

>
> 1) Refactor the asm/vdso.h to avoid vdso.lds syntax error.
>
> 2) Move vdso data page up front
Move  vdso data page before code page could save the problem which the 
.text

section could be bigger than PAGE_SIZE.

> and introduce enum vvar_pages, To pave the
> way for the subsequent support of TIME_NS, the support of TIME_NS will be
> issued in the later patch.
This makes it easier to introduce new features TIME_NS.

>
> 3) In arch_setup_additional_pages(), make Wait for the lock in the
> killable mode and return with EINTR if the task got killed while waiting.
For series,

Reviewed-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> Tong Tiangen (3):
>    riscv/vdso: Refactor asm/vdso.h
>    riscv/vdso: Move vdso data page up front
>    riscv/vdso: make arch_setup_additional_pages wait for mmap_sem for
>      write killable
>
>   arch/riscv/include/asm/syscall.h  |  1 +
>   arch/riscv/include/asm/vdso.h     | 10 ++----
>   arch/riscv/kernel/syscall_table.c |  1 -
>   arch/riscv/kernel/vdso.c          | 53 +++++++++++++++++++------------
>   arch/riscv/kernel/vdso/vdso.lds.S |  3 +-
>   5 files changed, 39 insertions(+), 29 deletions(-)
>