linux-kernel - Re: [PATCH] selftests: openat2: Fix testing failure for O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9dc1616-61b9-c010-950c-521693c74247@linuxfoundation.org>
Date:   Mon, 23 Aug 2021 13:23:26 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>, shuah@...nel.org,
        Christian Brauner <christian@...uner.io>,
        Aleksa Sarai <cyphar@...har.com>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: openat2: Fix testing failure for O_LARGEFILE
 flag

Hi Baolin,

On 8/22/21 8:40 PM, Baolin Wang wrote:
> Hi Shuah,
> 
> On 2021/7/28 20:32, Baolin Wang wrote:
>> Hi,
>>
>>> When running the openat2 test suite on ARM64 platform, we got below failure,
>>> since the definition of the O_LARGEFILE is different on ARM64. So we can
>>> set the correct O_LARGEFILE definition on ARM64 to fix this issue.
>>
>> Sorry, I forgot to copy the failure log:
>>

Please cc everybody get_maintainers.pl suggests. You are missing
key reviewers for this change.

Adding Christian Brauner and Aleksa Sarai to the thread.

>> # openat2 unexpectedly returned # 3['/lkp/benchmarks/kernel_selftests/tools/testing/selftests/openat2'] with 208000 (!= 208000)

Not sure I understand this. 208000 (!= 208000) look sthe same to me.

>> not ok 102 openat2 with incompatible flags (O_PATH | O_LARGEFILE) fails with -22 (Invalid argument)
>>
>>>
>>> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> 
> Could you apply this patch if no objection from your side? Thanks.
> 

Ideally this define should come from an include file.

Christian, Aleksa,

Can you review this patch and let me know if this approach looks right.

>>> ---
>>>   tools/testing/selftests/openat2/openat2_test.c | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/tools/testing/selftests/openat2/openat2_test.c b/tools/testing/selftests/openat2/openat2_test.c
>>> index d7ec1e7..1bddbe9 100644
>>> --- a/tools/testing/selftests/openat2/openat2_test.c
>>> +++ b/tools/testing/selftests/openat2/openat2_test.c
>>> @@ -22,7 +22,11 @@
>>>    * XXX: This is wrong on {mips, parisc, powerpc, sparc}.
>>>    */
>>>   #undef    O_LARGEFILE
>>> +#ifdef __aarch64__
>>> +#define    O_LARGEFILE 0x20000
>>> +#else
>>>   #define    O_LARGEFILE 0x8000
>>> +#endif
>>>   struct open_how_ext {
>>>       struct open_how inner;
>>>
> 

thanks,
-- Shuah