linux-kernel - [PATCH linux-next] include:ima: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210824060506.58942-1-deng.changcheng@zte.com.cn>
Date:   Mon, 23 Aug 2021 23:05:06 -0700
From:   CGEL <cgel.zte@...il.com>
To:     Mimi Zohar <zohar@...ux.ibm.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kees Cook <keescook@...omium.org>,
        KP Singh <kpsingh@...gle.com>,
        Tyler Hicks <tyhicks@...ux.microsoft.com>,
        Tushar Sugandhi <tusharsu@...ux.microsoft.com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Scott Branden <scott.branden@...adcom.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        linux-kernel@...r.kernel.org,
        Jing Yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: [PATCH linux-next] include:ima: fix boolreturn.cocci warnings

From: Jing Yangyang <jing.yangyang@....com.cn>

./include/linux/ima.h:189:8-9:WARNING:return of 0/1 in function
'is_ima_appraise_enabled' with return type bool

Return statements in functions returning bool should use true/false
instead of 1/0.

Generated by: scripts/coccinelle/misc/boolreturn.cocci

Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: Jing Yangyang <jing.yangyang@....com.cn>
---
 include/linux/ima.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/ima.h b/include/linux/ima.h
index b6ab66a..15b4938 100644
--- a/include/linux/ima.h
+++ b/include/linux/ima.h
@@ -186,7 +186,7 @@ extern int ima_inode_setxattr(struct dentry *dentry, const char *xattr_name,
 #else
 static inline bool is_ima_appraise_enabled(void)
 {
-	return 0;
+	return false;
 }
 
 static inline void ima_inode_post_setattr(struct user_namespace *mnt_userns,
-- 
1.8.3.1