linux-kernel - Re: [PATCH v2] clk: qcom: gcc-sdm660: Replace usage of parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f46e9c0a-970b-9391-66d4-70cf514fd93b@somainline.org>
Date:   Wed, 25 Aug 2021 23:23:47 +0200
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        angelogioacchino.delregno@...ainline.org
Subject: Re: [PATCH v2] clk: qcom: gcc-sdm660: Replace usage of parent_names

Hi Bjorn,

On 8/25/21 10:45 PM, Bjorn Andersson wrote:
> Using parent_data and parent_hws, instead of parent_names, does protect
> against some cases of incompletely defined clock trees. While it turns
> out that the bug being chased this time was totally unrelated, this
> patch converts the SDM660 GCC driver to avoid such issues.
> 
> The "xo" fixed_factor clock is unused within the gcc driver, but
> referenced from the DSI PHY. So it's left in place until the DSI driver
> is updated.
> 
> Tested-by: Marijn Suijten <marijn.suijten@...ainline.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
> Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
> 
> Changes since v1:
> - Added "xo" back to avoid regression in the DSI PHY


Tested again on the XA2 Ultra just to be sure, all is good now. Thanks!

- Marijn