linux-kernel - Re: [PATCH linux-next] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <344b7b12-4134-883c-1e0a-cdab7800067f@canonical.com>
Date:   Wed, 25 Aug 2021 11:45:58 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     CGEL <cgel.zte@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Dmitry Osipenko <digetx@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Cc:     Jing Yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] memory:tegra210-emc-core: replace
 DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

On 25/08/2021 08:37, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@....com.cn>
> 
> Fix the following coccicheck warning:
> ./drivers/memory/tegra/tegra210-emc-core.c:1665:0-23:WARNING
> tegra210_emc_debug_min_rate_fops should be defined
>  with DEFINE_DEBUGFS_ATTRIBUTE
> ./drivers/memory/tegra/tegra210-emc-core.c:1726:0-23:WARNING
> tegra210_emc_debug_temperature_fops should be defined
>  with DEFINE_DEBUGFS_ATTRIBUTE

Thanks for the patch.

One error message is enough. They are the same.

> 
> Reported-by: Zeal Robot <zealci@....com.cn>

Where is the report? We work here in a public, so if there is a report I
assume we can reach it? In case the report does not exist, anyone can
run checkpatch, coccinelle, smatch and sparse, so how does this differs
from me running checkpatch?


> Signed-off-by: Jing Yangyang <jing.yangyang@....com.cn>
> ---
>  drivers/memory/tegra/tegra210-emc-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c
> index 06c0f17..3b8284c 100644
> --- a/drivers/memory/tegra/tegra210-emc-core.c
> +++ b/drivers/memory/tegra/tegra210-emc-core.c
> @@ -1692,7 +1692,7 @@ static int tegra210_emc_debug_max_rate_set(void *data, u64 rate)
>  	return 0;
>  }
>  
> -DEFINE_SIMPLE_ATTRIBUTE(tegra210_emc_debug_max_rate_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(tegra210_emc_debug_max_rate_fops,
>  			tegra210_emc_debug_max_rate_get,
>  			tegra210_emc_debug_max_rate_set, "%llu\n");
>  
> @@ -1723,7 +1723,7 @@ static int tegra210_emc_debug_temperature_set(void *data, u64 temperature)
>  	return 0;
>  }
>  
> -DEFINE_SIMPLE_ATTRIBUTE(tegra210_emc_debug_temperature_fops,
> +DEFINE_DEBUGFS_ATTRIBUTE(tegra210_emc_debug_temperature_fops,
>  			tegra210_emc_debug_temperature_get,
>  			tegra210_emc_debug_temperature_set, "%llu\n");
>  
> 


Best regards,
Krzysztof