linux-kernel - Re: [PATCH linux-next] memory:tegra210-emc-core: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210825100149.GR7722@kadam>
Date:   Wed, 25 Aug 2021 13:01:49 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     CGEL <cgel.zte@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Dmitry Osipenko <digetx@...il.com>,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        Jing Yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] memory:tegra210-emc-core: replace
 DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

On Wed, Aug 25, 2021 at 11:45:58AM +0200, Krzysztof Kozlowski wrote:
> On 25/08/2021 08:37, CGEL wrote:
> > From: Jing Yangyang <jing.yangyang@....com.cn>
> > 
> > Fix the following coccicheck warning:
> > ./drivers/memory/tegra/tegra210-emc-core.c:1665:0-23:WARNING
> > tegra210_emc_debug_min_rate_fops should be defined
> >  with DEFINE_DEBUGFS_ATTRIBUTE
> > ./drivers/memory/tegra/tegra210-emc-core.c:1726:0-23:WARNING
> > tegra210_emc_debug_temperature_fops should be defined
> >  with DEFINE_DEBUGFS_ATTRIBUTE
> 
> Thanks for the patch.
> 
> One error message is enough. They are the same.
> 
> > 
> > Reported-by: Zeal Robot <zealci@....com.cn>
> 
> Where is the report? We work here in a public, so if there is a report I
> assume we can reach it? In case the report does not exist, anyone can
> run checkpatch, coccinelle, smatch and sparse, so how does this differs
> from me running checkpatch?

Someone asked for these tags when it was Huawei sending patches from
the Hulk Robot so no everyone adds them and Hulk Robot is the #1 bug
reporter.  Hulk Robot just crossed the 2000 tag mark recently.

regards,
dan carpenter