linux-kernel - drivers/staging/media/atomisp/i2c/atomisp-gc2235.c:567:6: warning: variable 'ret' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 25 Aug 2021 22:09:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     clang-built-linux@...glegroups.com, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: drivers/staging/media/atomisp/i2c/atomisp-gc2235.c:567:6: warning:
 variable 'ret' set but not used

Hi Mauro,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   6e764bcd1cf72a2846c0e53d3975a09b242c04c9
commit: aa31f6514047da6460e3db8247c2cefe3e08f6d9 media: atomisp: allow building the driver again
date:   1 year, 3 months ago
config: x86_64-randconfig-r003-20210825 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d26000e4cc2bc65e207a84fa26cb6e374d60aa12)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=aa31f6514047da6460e3db8247c2cefe3e08f6d9
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout aa31f6514047da6460e3db8247c2cefe3e08f6d9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/media/atomisp/i2c/atomisp-gc2235.c:567:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
           int ret = -1;
               ^
   1 warning generated.


vim +/ret +567 drivers/staging/media/atomisp/i2c/atomisp-gc2235.c

ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  563  
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  564  static int gpio_ctrl(struct v4l2_subdev *sd, bool flag)
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  565  {
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  566  	struct gc2235_device *dev = to_gc2235_sensor(sd);
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19 @567  	int ret = -1;
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  568  
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  569  	if (!dev || !dev->platform_data)
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  570  		return -ENODEV;
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  571  
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  572  	ret |= dev->platform_data->gpio1_ctrl(sd, !flag);
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  573  	usleep_range(60, 90);
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  574  	return dev->platform_data->gpio0_ctrl(sd, flag);
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  575  }
ad85094b293e40 Mauro Carvalho Chehab 2020-04-19  576  

:::::: The code at line 567 was first introduced by commit
:::::: ad85094b293e40e7a2f831b0311a389d952ebd5e Revert "media: staging: atomisp: Remove driver"

:::::: TO: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (33056 bytes)