linux-kernel - Re: [PATCH v2] clk: qcom: gcc-sdm660: Replace usage of parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <163020903534.2218116.16710170594346529772@swboyd.mtv.corp.google.com>
Date:   Sat, 28 Aug 2021 20:50:35 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        Michael Turquette <mturquette@...libre.com>
Cc:     linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        Martin Botka <martin.botka@...ainline.org>
Subject: Re: [PATCH v2] clk: qcom: gcc-sdm660: Replace usage of parent_names

Quoting Marijn Suijten (2021-08-26 12:16:57)
> Hi Stephen,
> 
> On 8/26/21 8:47 PM, Stephen Boyd wrote:
> > Quoting Bjorn Andersson (2021-08-25 13:45:17)
> >> Using parent_data and parent_hws, instead of parent_names, does protect
> >> against some cases of incompletely defined clock trees. While it turns
> >> out that the bug being chased this time was totally unrelated, this
> >> patch converts the SDM660 GCC driver to avoid such issues.
> >>
> >> The "xo" fixed_factor clock is unused within the gcc driver, but
> >> referenced from the DSI PHY. So it's left in place until the DSI driver
> >> is updated.
> >>
> >> Tested-by: Marijn Suijten <marijn.suijten@...ainline.org>
> >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
> >> Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>
> >> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> >> ---
> > 
> > Applied to clk-next after moving back the arrays so the diff is smaller.
> > 
> 
> Unfortunately the arrays cannot be moved back up since they (for the 
> most part) reference gpll clocks in `.hw = &gpll*` fields - these have 
> to be defined first or forward-declared otherwise, which is why the 
> arrays were moved down in the first place.
> 
> The general structure nowadays seems to place these parent maps/data 
> right above the clock that uses them, making it easier to read.
> 

Yes I applied a patch that only moved the arrays around first.