| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202108291318.E0dEhedA-lkp@intel.com>
Date: Sun, 29 Aug 2021 13:08:35 +0800
From: kernel test robot <lkp@...el.com>
To: Megha Dey <megha.dey@...el.com>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org
Subject: [meghadey-crypto:d_msix 1/1] drivers/pci/msi.c:805: warning:
expecting prototype for msix_capability_init(). Prototype was for
msix_setup_table() instead
tree: https://github.com/meghadey/crypto d_msix
head: 2c80823a6d6f4430df957092cbd837b55d52e3ae
commit: 2c80823a6d6f4430df957092cbd837b55d52e3ae [1/1] PCI/MSI: Dynamic allocation of MSI-X vectors
config: arm64-randconfig-r001-20210829 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 510e106fa8635e7f9c51c896180b971de6309b2f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/meghadey/crypto/commit/2c80823a6d6f4430df957092cbd837b55d52e3ae
git remote add meghadey-crypto https://github.com/meghadey/crypto
git fetch --no-tags meghadey-crypto d_msix
git checkout 2c80823a6d6f4430df957092cbd837b55d52e3ae
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/pci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/pci/msi.c:801: warning: Incorrect use of kernel-doc format: * msix_setup_table - Setup the MSI-X table of the device
>> drivers/pci/msi.c:805: warning: expecting prototype for msix_capability_init(). Prototype was for msix_setup_table() instead
vim +805 drivers/pci/msi.c
75cb3426878d47 Hidetoshi Seto 2009-08-06 788
^1da177e4c3f41 Linus Torvalds 2005-04-16 789 /**
^1da177e4c3f41 Linus Torvalds 2005-04-16 790 * msix_capability_init - configure device's MSI-X capability
^1da177e4c3f41 Linus Torvalds 2005-04-16 791 * @dev: pointer to the pci_dev data structure of MSI-X device function
8f7020d36374dd Randy Dunlap 2005-10-23 792 * @entries: pointer to an array of struct msix_entry entries
8f7020d36374dd Randy Dunlap 2005-10-23 793 * @nvec: number of @entries
f6b6aefee70aa5 Bjorn Helgaas 2019-05-30 794 * @affd: Optional pointer to enable automatic affinity assignment
^1da177e4c3f41 Linus Torvalds 2005-04-16 795 *
eaae4b3a84a378 Steven Cole 2005-05-03 796 * Setup the MSI-X capability structure of device function with a
f6b6aefee70aa5 Bjorn Helgaas 2019-05-30 797 * single MSI-X IRQ. A return of zero indicates the successful setup of
f6b6aefee70aa5 Bjorn Helgaas 2019-05-30 798 * requested MSI-X entries with allocated IRQs or non-zero for otherwise.
^1da177e4c3f41 Linus Torvalds 2005-04-16 799 **/
2c80823a6d6f44 Megha Dey 2021-08-26 800 /**
2c80823a6d6f44 Megha Dey 2021-08-26 801 * msix_setup_table - Setup the MSI-X table of the device
2c80823a6d6f44 Megha Dey 2021-08-26 802 * @dev: pointer to the pci_dev data structure of MSI-X device function
2c80823a6d6f44 Megha Dey 2021-08-26 803 */
2c80823a6d6f44 Megha Dey 2021-08-26 804 static int msix_setup_table(struct pci_dev *dev)
^1da177e4c3f41 Linus Torvalds 2005-04-16 @805 {
2c80823a6d6f44 Megha Dey 2021-08-26 806 int tsize;
7d5ec3d3612396 Thomas Gleixner 2021-07-29 807 u16 control;
^1da177e4c3f41 Linus Torvalds 2005-04-16 808
438553958ba192 Thomas Gleixner 2021-07-29 809 /*
438553958ba192 Thomas Gleixner 2021-07-29 810 * Some devices require MSI-X to be enabled before the MSI-X
438553958ba192 Thomas Gleixner 2021-07-29 811 * registers can be accessed. Mask all the vectors to prevent
438553958ba192 Thomas Gleixner 2021-07-29 812 * interrupts coming in before they're fully set up.
438553958ba192 Thomas Gleixner 2021-07-29 813 */
438553958ba192 Thomas Gleixner 2021-07-29 814 pci_msix_clear_and_set_ctrl(dev, 0, PCI_MSIX_FLAGS_MASKALL |
438553958ba192 Thomas Gleixner 2021-07-29 815 PCI_MSIX_FLAGS_ENABLE);
66f0d0c40c08c1 Yijing Wang 2014-06-19 816 pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &control);
^1da177e4c3f41 Linus Torvalds 2005-04-16 817 /* Request & Map MSI-X table region */
7d5ec3d3612396 Thomas Gleixner 2021-07-29 818 tsize = msix_table_size(control);
2c80823a6d6f44 Megha Dey 2021-08-26 819 dev->msix_table_base = msix_map_region(dev, tsize);
2c80823a6d6f44 Megha Dey 2021-08-26 820 if (!dev->msix_table_base) {
2c80823a6d6f44 Megha Dey 2021-08-26 821 pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
2c80823a6d6f44 Megha Dey 2021-08-26 822 return -ENOMEM;
438553958ba192 Thomas Gleixner 2021-07-29 823 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 824
7d5ec3d3612396 Thomas Gleixner 2021-07-29 825 /* Ensure that all table entries are masked. */
2c80823a6d6f44 Megha Dey 2021-08-26 826 msix_mask_all(dev->msix_table_base, tsize);
2c80823a6d6f44 Megha Dey 2021-08-26 827 return 0;
2c80823a6d6f44 Megha Dey 2021-08-26 828 }
2c80823a6d6f44 Megha Dey 2021-08-26 829
:::::: The code at line 805 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (30116 bytes)
Powered by blists - more mailing lists