linux-kernel - Re: [PATCH] iio: adc: twl6030-gpadc: Use the defined variable to clean code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210830123220.55980d62@jic23-huawei>
Date:   Mon, 30 Aug 2021 12:32:20 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Tang Bin <tangbin@...s.chinamobile.com>
Cc:     lars@...afoo.de, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: twl6030-gpadc: Use the defined variable to
 clean code

On Mon, 23 Aug 2021 17:59:21 +0800
Tang Bin <tangbin@...s.chinamobile.com> wrote:

> Use the defined variable "dev" to make the code cleaner.
> 
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
Applied.

Thanks,

> ---
>  drivers/iio/adc/twl6030-gpadc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index 0859f3f7d..5e4fbb033 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -897,7 +897,7 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
>  
>  	ret = pdata->calibrate(gpadc);
>  	if (ret < 0) {
> -		dev_err(&pdev->dev, "failed to read calibration registers\n");
> +		dev_err(dev, "failed to read calibration registers\n");
>  		return ret;
>  	}
>  
> @@ -911,14 +911,14 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
>  
>  	ret = twl6030_gpadc_enable_irq(TWL6030_GPADC_RT_SW1_EOC_MASK);
>  	if (ret < 0) {
> -		dev_err(&pdev->dev, "failed to enable GPADC interrupt\n");
> +		dev_err(dev, "failed to enable GPADC interrupt\n");
>  		return ret;
>  	}
>  
>  	ret = twl_i2c_write_u8(TWL6030_MODULE_ID1, TWL6030_GPADCS,
>  					TWL6030_REG_TOGGLE1);
>  	if (ret < 0) {
> -		dev_err(&pdev->dev, "failed to enable GPADC module\n");
> +		dev_err(dev, "failed to enable GPADC module\n");
>  		return ret;
>  	}
>