linux-kernel - Re: [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Aug 2021 11:02:28 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Jianjun Wang <jianjun.wang@...iatek.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Ryder Lee <ryder.lee@...iatek.com>,
        PCI <linux-pci@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>, devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Rex-BC.Chen@...iatek.com, Tinghan Shen <TingHan.Shen@...iatek.com>
Subject: Re: [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195

On Thu, Aug 26, 2021 at 9:26 PM Jianjun Wang <jianjun.wang@...iatek.com> wrote:
>
> MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192.
>
> Signed-off-by: Jianjun Wang <jianjun.wang@...iatek.com>
> ---
>  Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 742206dbd965..93e09c3029b7 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -48,7 +48,9 @@ allOf:
>
>  properties:
>    compatible:
> -    const: mediatek,mt8192-pcie
> +    enum:
> +      - mediatek,mt8192-pcie
> +      - mediatek,mt8195-pcie

I thought you wanted to support 8192 as the fallback:

compatible = "mediatek,mt8195-pcie", "mediatek,mt8192-pcie";

The above schema doesn't allow this.

Rob