linux-kernel - Re: [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36c66b737afa96563be128d822f862eea5839dcb.camel@mediatek.com>
Date:   Thu, 2 Sep 2021 02:07:34 +0000
From:   Jianjun Wang (王建军) 
        <Jianjun.Wang@...iatek.com>
To:     "robh+dt@...nel.org" <robh+dt@...nel.org>
CC:     "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        Ryder Lee (李庚諺) <Ryder.Lee@...iatek.com>,
        TingHan Shen (沈廷翰) 
        <TingHan.Shen@...iatek.com>,
        Rex-BC Chen (陳柏辰) 
        <Rex-BC.Chen@...iatek.com>
Subject: Re: [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for
 MT8195

On Mon, 2021-08-30 at 11:02 -0500, Rob Herring wrote:
> On Thu, Aug 26, 2021 at 9:26 PM Jianjun Wang <
> jianjun.wang@...iatek.com> wrote:
> > 
> > MT8195 is an ARM platform SoC which has the same PCIe IP with
> > MT8192.
> > 
> > Signed-off-by: Jianjun Wang <jianjun.wang@...iatek.com>
> > ---
> >  Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4
> > +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml
> > index 742206dbd965..93e09c3029b7 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -48,7 +48,9 @@ allOf:
> > 
> >  properties:
> >    compatible:
> > -    const: mediatek,mt8192-pcie
> > +    enum:
> > +      - mediatek,mt8192-pcie
> > +      - mediatek,mt8195-pcie
> 
> I thought you wanted to support 8192 as the fallback:
> 
> compatible = "mediatek,mt8195-pcie", "mediatek,mt8192-pcie";
> 
> The above schema doesn't allow this.
> 
> Rob

Hi Rob,

Yes, I want this fallback to support MT8195, but there are some un-
documented warnings if I don't add its compatible string to the yaml
file.

Do you have any suggestions in this case?

Thanks.