linux-kernel - Re: [PATCH v2] riscv: dts: microchip: mpfs-icicle: Fix serial console

Open Source and information security mailing list archives

Date:   Tue, 31 Aug 2021 11:26:13 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <geert@...ux-m68k.org>, <paul.walmsley@...ive.com>,
        <palmer@...belt.com>, <aou@...s.berkeley.edu>,
        <atish.patra@....com>
CC:     <bin.meng@...driver.com>, <linux-riscv@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <bmeng.cn@...il.com>
Subject: Re: [PATCH v2] riscv: dts: microchip: mpfs-icicle: Fix serial console

On 26/08/2021 14:19, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Currently, nothing is output on the serial console, unless
> "console=ttyS0,115200n8" or "earlycon" are appended to the kernel
> command line.  Enable automatic console selection using
> chosen/stdout-path by adding a proper alias, and configure the expected
> serial rate.
>
> While at it, add aliases for the other three serial ports, which are
> provided on the same micro-USB connector as the first one.
>
> Fixes: 0fa6107eca4186ad ("RISC-V: Initial DTS for Microchip ICICLE board")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Reviewed-by: Bin Meng <bmeng.cn@...il.com>
> ---
> v2:
>    - Add Reviewed-by,
>    - Rebase on top of 417166ddec020c4e ("riscv: dts: microchip: Add
>      ethernet0 to the aliases node"), as requested by Bin.
> ---
>   arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> index baea7d204639a185..b254c60589a1cc8b 100644
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> @@ -16,10 +16,14 @@ / {
>
>          aliases {
>                  ethernet0 = &emac1;
> +               serial0 = &serial0;
> +               serial1 = &serial1;
> +               serial2 = &serial2;
> +               serial3 = &serial3;
>          };
>
>          chosen {
> -               stdout-path = &serial0;
> +               stdout-path = "serial0:115200n8";
>          };
>
>          cpus {
> --
> 2.25.1

Looks good, we've switched to using this ourselves.
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives