linux-kernel - Re: [PATCH v2] riscv: dts: microchip: mpfs-icicle: Fix serial console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Sep 2021 23:58:57 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     geert@...ux-m68k.org
CC:     Paul Walmsley <paul.walmsley@...ive.com>, aou@...s.berkeley.edu,
        Atish Patra <Atish.Patra@....com>, bin.meng@...driver.com,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        geert@...ux-m68k.org, bmeng.cn@...il.com
Subject:     Re: [PATCH v2] riscv: dts: microchip: mpfs-icicle: Fix serial console

On Thu, 26 Aug 2021 06:19:39 PDT (-0700), geert@...ux-m68k.org wrote:
> Currently, nothing is output on the serial console, unless
> "console=ttyS0,115200n8" or "earlycon" are appended to the kernel
> command line.  Enable automatic console selection using
> chosen/stdout-path by adding a proper alias, and configure the expected
> serial rate.
>
> While at it, add aliases for the other three serial ports, which are
> provided on the same micro-USB connector as the first one.
>
> Fixes: 0fa6107eca4186ad ("RISC-V: Initial DTS for Microchip ICICLE board")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Reviewed-by: Bin Meng <bmeng.cn@...il.com>
> ---
> v2:
>   - Add Reviewed-by,
>   - Rebase on top of 417166ddec020c4e ("riscv: dts: microchip: Add
>     ethernet0 to the aliases node"), as requested by Bin.
> ---
>  arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> index baea7d204639a185..b254c60589a1cc8b 100644
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> @@ -16,10 +16,14 @@ / {
>
>  	aliases {
>  		ethernet0 = &emac1;
> +		serial0 = &serial0;
> +		serial1 = &serial1;
> +		serial2 = &serial2;
> +		serial3 = &serial3;
>  	};
>
>  	chosen {
> -		stdout-path = &serial0;
> +		stdout-path = "serial0:115200n8";
>  	};
>
>  	cpus {

Thanks, this is on for-next (there's no fixes right now, it's still 5.15 
for me).