linux-kernel - Re: [PATCH] net: NET_VENDOR_LITEX should depend on LITEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACPK8XfyYpWTmaASuG7Jkyp06fRrg_zXvg93JB7igZgVDWjumw@mail.gmail.com>
Date:   Tue, 31 Aug 2021 13:36:55 +0000
From:   Joel Stanley <joel@....id.au>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Gabriel Somlo <gsomlo@...il.com>, David Shah <dave@....me>,
        Stafford Horne <shorne@...il.com>,
        Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: NET_VENDOR_LITEX should depend on LITEX

On Tue, 31 Aug 2021 at 13:21, Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
>
> LiteX Ethernet devices are only present on LiteX SoCs.  Hence add a
> dependency on LITEX, to prevent asking the user about drivers for these
> devices when configuring a kernel without LiteX SoC Builder support.

nak.

They can be present on any soc that uses them. We have an example in
mainline already; microwatt uses liteeth but is not a litex soc.

Cheers,

Joel

>
> Fixes: ee7da21ac4c3be1f ("net: Add driver for LiteX's LiteETH network interface")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/net/ethernet/litex/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig
> index 265dba414b41ec22..bfad1df1368866d3 100644
> --- a/drivers/net/ethernet/litex/Kconfig
> +++ b/drivers/net/ethernet/litex/Kconfig
> @@ -5,6 +5,7 @@
>  config NET_VENDOR_LITEX
>         bool "LiteX devices"
>         default y
> +       depends on LITEX || COMPILE_TEST
>         help
>           If you have a network (Ethernet) card belonging to this class, say Y.
>
> --
> 2.25.1
>