linux-kernel - Re: [PATCH] net: NET_VENDOR_LITEX should depend on LITEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 31 Aug 2021 17:52:37 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Joel Stanley <joel@....id.au>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Gabriel Somlo <gsomlo@...il.com>, David Shah <dave@....me>,
        Stafford Horne <shorne@...il.com>,
        Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        Networking <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: NET_VENDOR_LITEX should depend on LITEX

Hi Joel,

On Tue, Aug 31, 2021 at 3:37 PM Joel Stanley <joel@....id.au> wrote:
> On Tue, 31 Aug 2021 at 13:21, Geert Uytterhoeven
> <geert+renesas@...der.be> wrote:
> > LiteX Ethernet devices are only present on LiteX SoCs.  Hence add a
> > dependency on LITEX, to prevent asking the user about drivers for these
> > devices when configuring a kernel without LiteX SoC Builder support.
>
> nak.
>
> They can be present on any soc that uses them. We have an example in
> mainline already; microwatt uses liteeth but is not a litex soc.

But liiteeth.c uses <linux/litex.h>?
And https://github.com/enjoy-digital/litex can be used with a microwatt
CPU core?

The idea behind the LITEX config symbol was to gate off any driver
using LiteX interfaces.

> > Fixes: ee7da21ac4c3be1f ("net: Add driver for LiteX's LiteETH network interface")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

> > --- a/drivers/net/ethernet/litex/Kconfig
> > +++ b/drivers/net/ethernet/litex/Kconfig
> > @@ -5,6 +5,7 @@
> >  config NET_VENDOR_LITEX
> >         bool "LiteX devices"
> >         default y
> > +       depends on LITEX || COMPILE_TEST
> >         help
> >           If you have a network (Ethernet) card belonging to this class, say Y.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds