linux-kernel - Re: [f2fs-dev] [PATCH 2/2] f2fs: should put a page beyond EOF when preparing a write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4ef1181-87e9-d76a-9084-29808aeef7b4@kernel.org>
Date:   Tue, 31 Aug 2021 10:04:24 +0800
From:   Chao Yu <chao@...nel.org>
To:     Jaegeuk Kim <jaegeuk@...nel.org>, linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: should put a page beyond EOF when
 preparing a write

On 2021/8/31 8:53, Jaegeuk Kim wrote:
> The prepare_compress_overwrite() gets/locks a page to prepare a read, and calls
> f2fs_read_multi_pages() which checks EOF first. If there's any page beyond EOF,
> we unlock the page and set cc->rpages[i] = NULL, which we can't put the page
> anymore. This makes page leak, so let's fix by putting that page.
> 

Fixes: a949dc5f2c5c ("f2fs: compress: fix race condition of overwrite vs truncate")

> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,