linux-kernel - Re: [PATCH][next] futex: fix assigned ret variable that is never read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5682c44f-3a02-c2b1-25d3-36db34b00356@collabora.com>
Date:   Wed, 1 Sep 2021 15:26:34 -0300
From:   André Almeida <andrealmeid@...labora.com>
To:     Colin King <colin.king@...onical.com>
Cc:     kernel-janitors@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Davidlohr Bueso <dave@...olabs.net>,
        Darren Hart <dvhart@...radead.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH][next] futex: fix assigned ret variable that is never read

Hi Colin,

Às 10:18 de 18/08/21, Colin King escreveu:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently the check on the rt_waiter and top_waiter->pi_state is
> assigning an error return code to ret but this later gets re-assigned,
> hence the check is currently ineffective. I believe the original
> intent was to return -EINVAL rather than assign it to ret. Fix this.
> 
> Addresses-Coverity: ("Unused value")
> Fixes: dc7109aaa233 ("futex: Validate waiter correctly in futex_proxy_trylock_atomic()")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>> ---

Reviewed-by: André Almeida <andrealmeid@...labora.com>