linux-kernel - Re: Question on commit dc7109aaa233 ("futex: Validate waiter correctly in futex_proxy_trylock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9689421-a801-fd8d-b0bd-29280bebe78d@collabora.com>
Date:   Wed, 1 Sep 2021 15:28:16 -0300
From:   André Almeida <andrealmeid@...labora.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Ingo Molnar <mingo@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Colin King <colin.king@...onical.com>
Subject: Re: Question on commit dc7109aaa233 ("futex: Validate waiter
 correctly in futex_proxy_trylock_atomic()")

Thomas,

Às 20:29 de 30/08/21, Thomas Gleixner escreveu:
> Lukas,
> 
> On Fri, Aug 20 2021 at 13:17, Lukas Bulwahn wrote:
>> Did you intend to return -EINVAL here? So:
>>
>> +       if (!top_waiter->rt_waiter || top_waiter->pi_state)
>> +               return -EINVAL;
> 
> Duh, yes.
> 
>> Static analysis tools are as foolish as they are... but every dog has its day...
> 
> IOW: Even a blind hen sometimes finds a grain of corn :)
> 
> Care to send a patch?
> 

A patch was already proposed with this fix:
https://lore.kernel.org/lkml/20210818131840.34262-1-colin.king@canonical.com/