linux-kernel - RE: [PATCH 0/2] arm: aspeed: Add LPC uart routing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <KL1PR0601MB37810C5AB662895C0C716C8391CD9@KL1PR0601MB3781.apcprd06.prod.outlook.com>
Date:   Wed, 1 Sep 2021 07:09:46 +0000
From:   ChiaWei Wang <chiawei_wang@...eedtech.com>
To:     Joel Stanley <joel@....id.au>,
        John Wang <wangzhiqiang.bj@...edance.com>,
        Lei YU <yulei.sh@...edance.com>
CC:     Rob Herring <robh+dt@...nel.org>, Andrew Jeffery <andrew@...id.au>,
        Oskar Senft <osk@...gle.com>,
        devicetree <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-aspeed <linux-aspeed@...ts.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>
Subject: RE: [PATCH 0/2] arm: aspeed: Add LPC uart routing support

Hi Joel,

> From: Joel Stanley <joel@....id.au>
> Sent: Wednesday, September 1, 2021 3:04 PM
> 
> On Wed, 1 Sept 2021 at 06:22, Chia-Wei Wang
> <chiawei_wang@...eedtech.com> wrote:
> >
> > Add LPC uart routing driver and the device tree nodes.
> 
> Thanks for submitting this driver. There are many parties who are interested in
> this, so hopefully they can step forward and review.
> 
> Is this LPC UART routing, or UART routing in general? I know the register to
> control the routing is hidden in the LPC space, but I thought it was just general
> routing. I would drop the LPC part of the name.
> 
> You also need to update the bindings document with the new compatible string.
> Send a patch for Documentation/devicetree/bindings/mfd/aspeed-lpc.txt.

Thanks for the feedback.

The UART routing is general.
I will send a v2 patch which drops the LPC part of name.
And the compatible string will also be updated to the dt-bindings.

Chiawei