linux-kernel - Re: [PATCH 04/13] ASoC: dt-bindings: tegra: Few more Tegra210 AHUB modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47f1d2ad-40a1-4c8f-8658-11328d41ee1e@nvidia.com>
Date:   Wed, 1 Sep 2021 12:39:54 +0530
From:   Sameer Pujar <spujar@...dia.com>
To:     Rob Herring <robh@...nel.org>
CC:     <broonie@...nel.org>, <lgirdwood@...il.com>,
        <thierry.reding@...il.com>, <jonathanh@...dia.com>,
        <catalin.marinas@....com>, <will@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <kuninori.morimoto.gx@...esas.com>,
        <sharadg@...dia.com>, <alsa-devel@...a-project.org>,
        <devicetree@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 04/13] ASoC: dt-bindings: tegra: Few more Tegra210 AHUB
 modules

Hi Rob,

Thanks for feedback.


On 9/1/2021 1:51 AM, Rob Herring wrote:
> On Fri, Aug 27, 2021 at 03:03:50PM +0530, Sameer Pujar wrote:
>> This patch adds YAML schema for DT bindings of few AHUB modules.
>> These devices will be registered as ASoC components and bindings
>> will be used on Tegra210 and later chips. The bindings for below
>> mentioned modules are added:
>>
>>   * SFC (Sampling Frequency Converter)
>>   * MVC (Master Volume Control)
>>   * AMX (Audio Multiplexer)
>>   * ADX (Audio Demultiplexer)
>>   * Mixer
>>
>> Signed-off-by: Sameer Pujar <spujar@...dia.com>
>> Cc: Rob Herring <robh+dt@...nel.org>
>> ---
>>   .../bindings/sound/nvidia,tegra210-adx.yaml        | 74 ++++++++++++++++++++
>>   .../bindings/sound/nvidia,tegra210-ahub.yaml       | 20 ++++++
>>   .../bindings/sound/nvidia,tegra210-amx.yaml        | 72 ++++++++++++++++++++
>>   .../bindings/sound/nvidia,tegra210-mixer.yaml      | 67 ++++++++++++++++++
>>   .../bindings/sound/nvidia,tegra210-mvc.yaml        | 79 ++++++++++++++++++++++
>>   .../bindings/sound/nvidia,tegra210-sfc.yaml        | 76 +++++++++++++++++++++
>>   6 files changed, 388 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml
>>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml
>>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml
>>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml
>>   create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml

[...]

>> +  16 channels and demultiplexes it into four output streams of up to 16
>> +  channels each. A byte RAM helps to form output frames by any combination
>> +  of bytes from the input frame. Its design is identical to that of byte
>> +  RAM in the AMX except that the data flow direction is reversed.
>> +
>> +maintainers:
>> +  - Jon Hunter <jonathanh@...dia.com>
>> +  - Mohan Kumar <mkumard@...dia.com>
>> +  - Sameer Pujar <spujar@...dia.com>
>> +
>> +properties:
>> +  $nodename:
>> +    pattern: "^adx@[0-9a-f]*$"
>> +
>> +  compatible:
>> +    oneOf:
>> +      - const: nvidia,tegra210-adx
>> +      - items:
>> +          - enum:
>> +              - nvidia,tegra194-adx
>> +              - nvidia,tegra186-adx
>> +          - const: nvidia,tegra210-adx
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  sound-name-prefix:
> nvidia,sound-name-prefix

It is supposed to be 'sound-name-prefix' for core to parse and apply 
prefix. May be this needs to be directly referenced from 
'Documentation/devicetree/bindings/sound/name-prefix.txt' after 
converting to YAML, which can be a separate commit?


Remaining comments will be taken care in next revision.