linux-kernel - Re: drivers/crypto/qat/qat_c62xvf/adf_c62xvf_hw_data.c:102:28: warning: taking address of packed member 'csr_ops' of class or structure 'adf_hw_device_data' may result in an unaligned pointer value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Sep 2021 12:36:33 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     kernel test robot <lkp@...el.com>, llvm@...ts.linux.dev,
        kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Fiona Trahe <fiona.trahe@...el.com>,
        Wojciech Ziemba <wojciech.ziemba@...el.com>
Subject: Re: drivers/crypto/qat/qat_c62xvf/adf_c62xvf_hw_data.c:102:28:
 warning: taking address of packed member 'csr_ops' of class or structure
 'adf_hw_device_data' may result in an unaligned pointer value

On Wed, Sep 01, 2021 at 02:18:17PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 01, 2021 at 12:19:08AM +0800, kernel test robot wrote:
> > >> drivers/crypto/qat/qat_c62xvf/adf_c62xvf_hw_data.c:102:28: warning: taking address of packed member 'csr_ops' of class or structure 'adf_hw_device_data' may result in an unaligned pointer value [-Waddress-of-packed-member]
> >            adf_gen2_init_hw_csr_ops(&hw_data->csr_ops);
> >                                      ^~~~~~~~~~~~~~~~
> >    3 warnings generated.
> 
> 
> Why on Earth the struct adf_hw_device_data, that contains a lot of pointers,
> marked as __packed?! That __packed has to be dropped.
That struct doesn't need to be marked as __packed.
I'm going to send a patch that drops that attribute for all the
structures that do not need to be packed in the QAT driver.

-- 
Giovanni