linux-kernel - Re: [PATCH] ASoC: ti: rename CONFIG_SND_SOC_DM365_VOICE_CODEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Sep 2021 08:44:47 +0300
From:   Péter Ujfalusi <peter.ujfalusi@...il.com>
To:     Masahiro Yamada <masahiroy@...nel.org>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Jaroslav Kysela <perex@...ex.cz>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: ti: rename CONFIG_SND_SOC_DM365_VOICE_CODEC_MODULE



On 01/09/2021 19:40, Masahiro Yamada wrote:
> Kconfig generates include/generated/autoconf.h to make CONFIG options
> available to the pre-processor. Symbols with the value 'm' are suffixed
> with '_MODULE'
> 
> Here is a conflict; CONFIG_FOO=m results in '#define CONFIG_FOO_MODULE 1',
> but CONFIG_FOO_MODULE=y also results in the same define.
> 
> Also, CONFIG options that end with '_MODULE' confuse the Kconfig/fixdep
> interaction; fixdep always assumes CONFIG_FOO_MODULE comes from
> CONFIG_FOO=m, so the dependency is not properly tracked for symbols
> that end with '_MODULE'.
> 
> For these reasons, CONFIG options that end with '_MODULE' should be
> avoided in general. (I am planning on adding a check in Kconfig.)
> 
> This is the only case in the current kernel.
> 
> The new option name was suggested by Péter Ujfalusi. [1]
> 
> [1] https://lore.kernel.org/all/d9e777dc-d274-92ee-4d77-711bfd553611@gmail.com/
> 
> Fixes: 147162f57515 ("ASoC: ti: fix SND_SOC_DM365_VOICE_CODEC dependencies")
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Thank you,

Acked-by: Peter Ujfalusi <peter.ujfalusi@...il.com>

> ---
> 
>  sound/soc/ti/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/ti/Kconfig b/sound/soc/ti/Kconfig
> index 698d7bc84dcf..3260a30d3d54 100644
> --- a/sound/soc/ti/Kconfig
> +++ b/sound/soc/ti/Kconfig
> @@ -211,7 +211,7 @@ config SND_SOC_DM365_VOICE_CODEC
>  	  Say Y if you want to add support for SoC On-chip voice codec
>  endchoice
>  
> -config SND_SOC_DM365_VOICE_CODEC_MODULE
> +config SND_SOC_DM365_SELECT_VOICE_CODECS
>  	def_tristate y
>  	depends on SND_SOC_DM365_VOICE_CODEC && SND_SOC
>  	select MFD_DAVINCI_VOICECODEC
> 

-- 
Péter