linux-kernel - Re: [PATCH] binfmt: a.out: Fix bogus semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7a9e8a5e-df3d-0ecd-1396-450b50ce2937@redhat.com>
Date:   Sun, 5 Sep 2021 21:29:04 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Alexander Viro <viro@...iv.linux.org.uk>
Cc:     Christian König <christian.koenig@....com>,
        "Eric W . Biederman" <ebiederm@...ssion.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        noreply@...erman.id.au
Subject: Re: [PATCH] binfmt: a.out: Fix bogus semicolon

On 05.09.21 11:30, Geert Uytterhoeven wrote:
>      fs/binfmt_aout.c: In function ‘load_aout_library’:
>      fs/binfmt_aout.c:311:27: error: expected ‘)’ before ‘;’ token
>        311 |    MAP_FIXED | MAP_PRIVATE;
> 	  |                           ^
>      fs/binfmt_aout.c:309:10: error: too few arguments to function ‘vm_mmap’
>        309 |  error = vm_mmap(file, start_addr, ex.a_text + ex.a_data,
> 	  |          ^~~~~~~
>      In file included from fs/binfmt_aout.c:12:
>      include/linux/mm.h:2626:35: note: declared here
>       2626 | extern unsigned long __must_check vm_mmap(struct file *, unsigned long,
> 	  |                                   ^~~~~~~
> 
> Fix this by reverting the accidental replacement of a comma by a
> semicolon.
> 
> Fixes: 42be8b42535183f8 ("binfmt: don't use MAP_DENYWRITE when loading shared libraries via uselib()")
> Reported-by: noreply@...erman.id.au
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>   fs/binfmt_aout.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
> index a47496d0f123355c..0dcfc691e7e218bc 100644
> --- a/fs/binfmt_aout.c
> +++ b/fs/binfmt_aout.c
> @@ -308,7 +308,7 @@ static int load_aout_library(struct file *file)
>   	/* Now use mmap to map the library into memory. */
>   	error = vm_mmap(file, start_addr, ex.a_text + ex.a_data,
>   			PROT_READ | PROT_WRITE | PROT_EXEC,
> -			MAP_FIXED | MAP_PRIVATE;
> +			MAP_FIXED | MAP_PRIVATE,
>   			N_TXTOFF(ex));
>   	retval = error;
>   	if (error != start_addr)
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

Thanks for reporting and fixing that quickly!

-- 
Thanks,

David / dhildenb