linux-kernel - Re: [PATCH] arm: dts: sunxi: h3/h5: Fix I2S2 node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4281589.rpS0U0bY3j@kista>
Date:   Sun, 05 Sep 2021 21:40:50 +0200
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     mripard@...nel.org, wens@...e.org
Cc:     robh+dt@...nel.org, codekipper@...il.com, peron.clem@...il.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: dts: sunxi: h3/h5: Fix I2S2 node

Hi all,

Dne nedelja, 05. september 2021 ob 21:26:28 CEST je Jernej Skrabec napisal(a):
> I2S2 controller has RX DMA channel according to documentation.
> 

Sorry for mistake. This is not true. Documentation doesn't have RX DMA 
documented (I2S2 is connected to HDMI).

Marcus, do you remember if loopback mode actually works on H3, with DMA 
enabled? Maybe DMA is there, just undocumented. Some SoCs (H6, R40) have RX 
DMA channel documented, even though it's used for HDMI TX only, and others 
don't (A64, H3, H5).

Anyway, I got report that I2S driver from 5.14 onwards can't register 
controller anymore due to missing RX DMA channel. So either driver or DT has 
to be fixed.

Please disregard this patch for now.

Best regards,
Jernej

> Add it.
> 
> Fixes: cd7c897821a0 ("arm: dts: sunxi: h3/h5: Add I2S2 node")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@...il.com>
> ---
>  arch/arm/boot/dts/sunxi-h3-h5.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-
h5.dtsi
> index c7428df9469e..bd26f2059220 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -670,9 +670,9 @@ i2s2: i2s@...2800 {
>  			interrupts = <GIC_SPI 15 
IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&ccu CLK_BUS_I2S2>, <&ccu 
CLK_I2S2>;
>  			clock-names = "apb", "mod";
> -			dmas = <&dma 27>;
> +			dmas = <&dma 27>, <&dma 27>;
>  			resets = <&ccu RST_BUS_I2S2>;
> -			dma-names = "tx";
> +			dma-names = "tx", "rx";
>  			status = "disabled";
>  		};
>  
> -- 
> 2.33.0
> 
>