linux-kernel - Re: [PATCH v7 1/2] perf pmu: Add PMU alias support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce0e8ecd-94fc-886d-665a-744ceff5a129@linux.intel.com>
Date:   Sun, 5 Sep 2021 17:10:58 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     jolsa@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com, rickyman7@...il.com,
        john.garry@...wei.com, Kan Liang <kan.liang@...ux.intel.com>
Subject: Re: [PATCH v7 1/2] perf pmu: Add PMU alias support

Hi Arnaldo,

On 9/3/2021 7:38 PM, Arnaldo Carvalho de Melo wrote:
>      Committer notes:
>      
>      Rename 'struct perf_pmu_alias_name' to 'pmu_alias', the 'perf_' prefix
>      should be used for libperf, things inside just tools/perf/ are being
>      moved away from that prefix.
>      
>      Also 'pmu_alias' is shorter and reflects the abstraction.
>      
>      Also don't use 'pmu' as the name for variables for that type, we should
>      use that for the 'struct perf_pmu' variables, avoiding confusion. Use
>      'pmu_alias' for 'struct pmu_alias' variables.

I fully agree your recommended changes. I think Kan will agree too. :) Thanks so much!

Thanks
Jin Yao