linux-kernel - Re: [PATCH] mmc: mtk-sd: Remove unused parameters(mrq)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Sep 2021 19:10:00 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Chanwoo Lee <cw9316.lee@...sung.com>
Cc:     Chaotian Jing <chaotian.jing@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        grant.jung@...sung.com, jt77.jang@...sung.com,
        DooHyun Hwang <dh0421.hwang@...sung.com>,
        Seunghui Lee <sh043.lee@...sung.com>
Subject: Re: [PATCH] mmc: mtk-sd: Remove unused parameters(mrq)

On Fri, 27 Aug 2021 at 11:39, Chanwoo Lee <cw9316.lee@...sung.com> wrote:
>
> From: ChanWoo Lee <cw9316.lee@...sung.com>
>
> The mmc_request structure(*mrq) is not used. //msdc_cmd_find_resp
> I remove the unnecessary code related to the mmc_request structure.
>
> Signed-off-by: ChanWoo Lee <cw9316.lee@...sung.com>

Queued for v5.16 on the temporary devel branch, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mtk-sd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 4dfc246c5f95..813f57f6d9cc 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -961,7 +961,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
>  }
>
>  static inline u32 msdc_cmd_find_resp(struct msdc_host *host,
> -               struct mmc_request *mrq, struct mmc_command *cmd)
> +               struct mmc_command *cmd)
>  {
>         u32 resp;
>
> @@ -997,7 +997,7 @@ static inline u32 msdc_cmd_prepare_raw_cmd(struct msdc_host *host,
>          * stop << 14 | rw << 13 | dtype << 11 | rsptyp << 7 | brk << 6 | opcode
>          */
>         u32 opcode = cmd->opcode;
> -       u32 resp = msdc_cmd_find_resp(host, mrq, cmd);
> +       u32 resp = msdc_cmd_find_resp(host, cmd);
>         u32 rawcmd = (opcode & 0x3f) | ((resp & 0x7) << 7);
>
>         host->cmd_rsp = resp;
> --
> 2.29.0
>