linux-kernel - Re: [PATCH] mmc: mtk-sd: Remove unused parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Sep 2021 19:10:05 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Chanwoo Lee <cw9316.lee@...sung.com>
Cc:     Chaotian Jing <chaotian.jing@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>, grant.jung@...sung.com,
        jt77.jang@...sung.com, DooHyun Hwang <dh0421.hwang@...sung.com>,
        Seunghui Lee <sh043.lee@...sung.com>
Subject: Re: [PATCH] mmc: mtk-sd: Remove unused parameters

On Mon, 30 Aug 2021 at 04:25, Chanwoo Lee <cw9316.lee@...sung.com> wrote:
>
> From: ChanWoo Lee <cw9316.lee@...sung.com>
>
> Remove unused parameters
> 1. msdc_start_data() - struct mmc_request *mrq
> 2. msdc_track_cmd_data() - struct mmc_data *data
>
> Signed-off-by: ChanWoo Lee <cw9316.lee@...sung.com>

Queued for v5.16 on the temporary devel branch, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mtk-sd.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 4dfc246c5f95..a8736067c409 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1043,8 +1043,8 @@ static inline u32 msdc_cmd_prepare_raw_cmd(struct msdc_host *host,
>         return rawcmd;
>  }
>
> -static void msdc_start_data(struct msdc_host *host, struct mmc_request *mrq,
> -                           struct mmc_command *cmd, struct mmc_data *data)
> +static void msdc_start_data(struct msdc_host *host, struct mmc_command *cmd,
> +               struct mmc_data *data)
>  {
>         bool read;
>
> @@ -1112,8 +1112,7 @@ static void msdc_recheck_sdio_irq(struct msdc_host *host)
>         }
>  }
>
> -static void msdc_track_cmd_data(struct msdc_host *host,
> -                               struct mmc_command *cmd, struct mmc_data *data)
> +static void msdc_track_cmd_data(struct msdc_host *host, struct mmc_command *cmd)
>  {
>         if (host->error)
>                 dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n",
> @@ -1134,7 +1133,7 @@ static void msdc_request_done(struct msdc_host *host, struct mmc_request *mrq)
>         host->mrq = NULL;
>         spin_unlock_irqrestore(&host->lock, flags);
>
> -       msdc_track_cmd_data(host, mrq->cmd, mrq->data);
> +       msdc_track_cmd_data(host, mrq->cmd);
>         if (mrq->data)
>                 msdc_unprepare_data(host, mrq->data);
>         if (host->error)
> @@ -1295,7 +1294,7 @@ static void msdc_cmd_next(struct msdc_host *host,
>         else if (!cmd->data)
>                 msdc_request_done(host, mrq);
>         else
> -               msdc_start_data(host, mrq, cmd, cmd->data);
> +               msdc_start_data(host, cmd, cmd->data);
>  }
>
>  static void msdc_ops_request(struct mmc_host *mmc, struct mmc_request *mrq)
> --
> 2.29.0
>