linux-kernel - Re: [PATCH v3] Input: analog: Always use ktime functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15bf8c00-3a38-a1bd-8214-6f45608db3f0@infradead.org>
Date:   Tue, 7 Sep 2021 17:52:52 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Guenter Roeck <linux@...ck-us.net>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Input: analog: Always use ktime functions

On 9/7/21 5:37 AM, Guenter Roeck wrote:
> m68k, mips, s390, and sparc allmodconfig images fail to build with the
> following error.
> 
> drivers/input/joystick/analog.c:160:2: error:
> 	#warning Precise timer not defined for this architecture.
> 
> Remove architecture specific time handling code and always use ktime
> functions to determine time deltas. Also remove the now useless use_ktime
> kernel parameter.
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
> v3: Avoid 64-bit divide operation
> v2: Drop helper functions and use ktime_get() and ktime_sub() directly
>      Drop 'speed' variable and use NSEC_PER_MSEC directly
> 
>   drivers/input/joystick/analog.c | 103 ++++----------------------------
>   1 file changed, 11 insertions(+), 92 deletions(-)

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

thanks.
-- 
~Randy