linux-kernel - Re: [PATCH v3] Input: analog: Always use ktime functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YTgVUWzFSOg/I4C+@google.com>
Date:   Tue, 7 Sep 2021 18:43:45 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Input: analog: Always use ktime functions

Hi Guenter,

On Tue, Sep 07, 2021 at 05:37:34AM -0700, Guenter Roeck wrote:
> @@ -241,11 +176,11 @@ static int analog_cooked_read(struct analog_port *port)
>  	int i, j;
>  
>  	loopout = (ANALOG_LOOP_TIME * port->loop) / 1000;
> -	timeout = ANALOG_MAX_TIME * port->speed;
> +	timeout = ANALOG_MAX_TIME * NSEC_PER_MSEC;
>  
>  	local_irq_save(flags);
>  	gameport_trigger(gameport);
> -	now = get_time();
> +	now = ktime_get();

There are time[4], now, etc variables above this block that are u64. I
think they can be make ktime_t. I can do it myself if you agree.

> @@ -378,35 +313,19 @@ static void analog_calibrate_timer(struct analog_port *port)
>  	u64 t1, t2, t3;

I think these should also be ktime_t.

Thanks.

-- 
Dmitry