linux-kernel - Re: [PATCH] tpm/tpm_i2c_infineon: Fix init endian vendor check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210908134002.GY1200268@ziepe.ca>
Date:   Wed, 8 Sep 2021 10:40:02 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Florian Eckert <fe@....tdt.de>
Cc:     peterhuewe@....de, jarkko@...nel.org,
        Eckert.Florian@...glemail.com, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm/tpm_i2c_infineon: Fix init endian vendor check

On Wed, Sep 08, 2021 at 03:34:16PM +0200, Florian Eckert wrote:
> On my embedded system I use this tpm infineon chip via I2C.
> My system is a MIPS architecture and therefore works in big endian mode.
> 
> The problem is that the chip type is not recognised, because the vendor ID
> is incorrectly stored in memory.
> 
> By converting the vendor ID with ie32_to_cpus() to the correct format,
> the TPM chip is recognised by the driver and works as expected.
> 
> Signed-off-by: Florian Eckert <fe@....tdt.de>
> ---
>  drivers/char/tpm/tpm_i2c_infineon.c | 2 ++
>  1 file changed, 2 insertions(+)

vendor should be marked as a __le32 and so forth 

Jason