linux-kernel - Re: [PATCH] selftests/ftrace: Exclude "(fault)" in testing add/remove eprobe events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210908124757.b80638d630436bebf1280836@kernel.org>
Date:   Wed, 8 Sep 2021 12:47:57 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Tzvetomir Stoyanov <tz.stoyanov@...il.com>
Subject: Re: [PATCH] selftests/ftrace: Exclude "(fault)" in testing
 add/remove eprobe events

On Tue, 7 Sep 2021 23:04:29 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: "Steven Rostedt (VMware)" <rostedt@...dmis.org>
> 
> The original test for adding and removing eprobes used synthetic events
> and retrieved the filename from the open system call at the end of the
> system call. This would allow it to always be loaded into the page tables
> when accessed.
> 
> Masami suggested that the test was too complex for just testing add and
> remove, so it was changed to test just adding and removing an event probe
> on top of the start of the open system call event. Now it is possible that
> the filename will not be loaded into memory at the time the eprobe is
> triggered, and will result in "(fault)" being displayed in the event. This
> causes the test to fail.
> 
> Account for "(fault)" also being one of the values of the filename field
> of the event probe.

Looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you,

> 
> Fixes: 079db70794ec5 ("selftests/ftrace: Add test case to test adding and removing of event probe")
> Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> ---
>  .../selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc
> index 25a3da4eaa44..5f5b2ba3e557 100644
> --- a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc
> +++ b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc
> @@ -22,7 +22,7 @@ ls
>  echo 0 > events/eprobes/$EPROBE/enable
>  
>  content=`grep '^ *ls-' trace | grep 'file='`
> -nocontent=`grep '^ *ls-' trace | grep 'file=' | grep -v -e '"/' -e '"."'` || true
> +nocontent=`grep '^ *ls-' trace | grep 'file=' | grep -v -e '"/' -e '"."' -e '(fault)' ` || true
>  
>  if [ -z "$content" ]; then
>  	exit_fail
> -- 
> 2.31.1
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>