linux-kernel - Re: [PATCH v2] blk-zoned: Remove needless request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <952d7945-e876-f86e-b4a4-2190c876b64b@nvidia.com>
Date:   Fri, 10 Sep 2021 09:33:32 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Xu Wang <vulab@...as.ac.cn>, "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] blk-zoned: Remove needless request_queue NULL pointer
 checks

On 9/9/21 11:44 PM, Xu Wang wrote:
> External email: Use caution opening links or attachments
> 
> 
> The request_queue pointer returned from bdev_get_queue() shall
> never be NULL, so the NULL checks are unnecessary, just remove them.
> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> Changes since v2:
> - Make the q variable assignment together with declaration.
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>